Andrew/redot-engine
1
0
Fork 0
mirror of https://github.com/Redot-Engine/redot-engine.git synced 2025-12-05 23:07:42 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #103219 from kuruk-mm/fix-file-handle-leak

Browse Source 
Fix file handle leak in ZipArchive and FileAccessZip
This commit is contained in:
Thaddeus Crews
2025-06-24 09:58:43 -05:00
parent 3c9f6aa81f 38c69f1814
commit 27414203de
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
core/io/file_access_zip.cpp
View File

@@ -174,7 +174,6 @@ bool ZipArchive::try_open_pack(const String &p_path, bool p_replace_files, uint6
Package pkg;
pkg.filename = p_path;
pkg.zfile = zfile;
packages.push_back(pkg);
int pkg_num = packages.size() - 1;
@@ -201,6 +200,8 @@ bool ZipArchive::try_open_pack(const String &p_path, bool p_replace_files, uint6
}
}
unzClose(zfile);
return true;
}
@@ -225,10 +226,6 @@ ZipArchive::ZipArchive() {
}
ZipArchive::~ZipArchive() {
for (int i = 0; i < packages.size(); i++) {
unzClose(packages[i].zfile);
}
packages.clear();
}

1
core/io/file_access_zip.h
View File

@@ -47,7 +47,6 @@ public:
private:
struct Package {
String filename;
unzFile zfile = nullptr;
};
Vector<Package> packages;