Andrew/redot-engine
1
0
Fork 0
mirror of https://github.com/Redot-Engine/redot-engine.git synced 2025-12-06 07:17:42 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #108384 from adamscott/fix-sample-deletion

Browse Source 
[Web] Fix sample playback deletion and `AudioStreamPolyphonic` issue
This commit is contained in:
Thaddeus Crews
2025-08-03 10:50:49 -05:00
parent c2202d36c1 1328921e04
commit 321f2391d9
3 changed files with 26 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
platform/web/js/libs/library_godot_audio.js
View File

@@ -408,7 +408,7 @@ class SampleNode {
* @returns {void}
*/
static delete(id) {
GodotAudio.sampleNodes.delete(id);
GodotAudio.deleteSampleNode(id);
}
/**
@@ -776,15 +776,9 @@ class SampleNode {
}
switch (self.getSample().loopMode) {
case 'disabled': {
const id = this.id;
case 'disabled':
self.stop();
if (GodotAudio.sampleFinishedCallback != null) {
const idCharPtr = GodotRuntime.allocString(id);
GodotAudio.sampleFinishedCallback(idCharPtr);
GodotRuntime.free(idCharPtr);
}
} break;
break;
case 'forward':
case 'backward':
self.restart();
@@ -1175,6 +1169,15 @@ const _GodotAudio = {
*/
sampleNodes: null,
SampleNode,
deleteSampleNode: (pSampleNodeId) => {
GodotAudio.sampleNodes.delete(pSampleNodeId);
if (GodotAudio.sampleFinishedCallback == null) {
return;
}
const sampleNodeIdPtr = GodotRuntime.allocString(pSampleNodeId);
GodotAudio.sampleFinishedCallback(sampleNodeIdPtr);
GodotRuntime.free(sampleNodeIdPtr);
},
// `Bus` class
/**